Add rgh-feature-descriptions feature
#3852
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
FloEdelmann
commented
Dec 28, 2020
yakov116
reviewed
Dec 29, 2020
fregante
reviewed
Dec 29, 2020
fregante
reviewed
Dec 31, 2020
fregante
reviewed
Dec 31, 2020
fregante
reviewed
Dec 31, 2020
fregante
reviewed
Dec 31, 2020
fregante
requested changes
Jan 4, 2021
fregante
changed the title
feature-descriptions featurergh-feature-descriptions feature
fregante
reviewed
Jan 4, 2021
It neither needs to be documented nor should it be disableable. It's a meta feature
fregante
reviewed
Jan 4, 2021
fregante
approved these changes
Jan 5, 2021
rmacklin
reviewed
Aug 26, 2021
| @@ -59,7 +59,7 @@ function getFeatures(): FeatureID[] { | |||
| return Array.from( | |||
| readFileSync(path.join(__dirname, 'source/refined-github.ts'), 'utf-8').matchAll(/^import '\.\/features\/([^.]+)';/gm), | |||
| match => match[1] as FeatureID | |||
| ).sort(); | |||
| ).sort().filter(id => !id.startsWith('rgh-')); | |||
There was a problem hiding this comment.
@fregante Does this mean that we want to prevent features prefixed with rgh- from being togglable in the extension options? Or was that an unintended side effect of not requiring them to have descriptions in the README?
It seems like those are the only non-CSS features that can't be toggled from the extension options, which got me curious about them.
There was a problem hiding this comment.
Correct you cannot toggle them
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I picked up @yakov116's work from #3693, and added a few bits. I hope this is enough to close #3630.
Test URLs:
https://github.com/sindresorhus/refined-github/blob/master/source/features/batch-mark-files-as-viewed.tsx
Screenshot
https://github.com/sindresorhus/refined-github/blob/20.12.27/source/features/align-issue-labels.css
Screenshot
https://github.com/sindresorhus/refined-github/blob/20.12.27/source/features/clean-dashboard.ts
Screenshot