Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix separate-draft-pr-button position #3873

Merged
merged 3 commits into from
Jan 10, 2021
Merged

Fix separate-draft-pr-button position #3873

merged 3 commits into from
Jan 10, 2021

Conversation

cheap-glitch
Copy link
Member

@cheap-glitch cheap-glitch commented Jan 9, 2021 •
edited

Thanks for contributing! 馃崉

  1. LINKED ISSUES: Fix separate-draft-pr-button is in the wrong position聽#3871

  2. TEST URLS:

  1. SCREENSHOT:

Before After

Screenshot_2021-01-09 sindresorhus refined-github

Screenshot_2021-01-09 sindresorhus refined-github(1)

Bug was caused by a new wrapper around the PR form.

@fregante fregante changed the title Fix separate-draft-pr-button postioning Fix separate-draft-pr-button position Jan 9, 2021
@fregante fregante mentioned this pull request Jan 9, 2021
Merged
@fregante fregante added the bug label Jan 9, 2021
cheap-glitch and others added 2 commits January 9, 2021 23:32
@cheap-glitch @fregante
Use better selector
98e047a 
Co-authored-by: Federico <me@fregante.com>
@cheap-glitch
Fix code to account for new selector
3d00df0
@fregante fregante merged commit 434297a into refined-github:master Jan 10, 2021
@cheap-glitch cheap-glitch deleted the reposition-separate-draft-pr-button branch January 10, 2021 08:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fregante fregante Awaiting requested review from fregante

Assignees
No one assigned
Labels
bug
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

separate-draft-pr-button is in the wrong position
2 participants
@cheap-glitch @fregante