Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't list-prs-for-file while you're editing the same PR #3935

Merged
merged 4 commits into from Feb 5, 2021
Merged

Conversation

@yakov116 yakov116 added the bug label Feb 2, 2021
@fregante
Copy link
Member

fregante commented Feb 2, 2021

Try again. Use URLSearchParameters like we always do and just exclude it from the array. The feature should still show any other PR open for the file.

The current PR should be excluded from the list

@fregante fregante marked this pull request as draft February 2, 2021 13:18
@yakov116
Copy link
Member Author

yakov116 commented Feb 3, 2021

@fregante did you test with multiple PR's? I left it a draft since I did not test it yet.

@yakov116 yakov116 marked this pull request as ready for review February 5, 2021 04:07
@yakov116
Copy link
Member Author

yakov116 commented Feb 5, 2021

Title good?

@yakov116 yakov116 merged commit a069714 into main Feb 5, 2021
@yakov116 yakov116 deleted the list-pr branch February 5, 2021 04:23
@yakov116
Copy link
Member Author

yakov116 commented Feb 5, 2021

Thanks for going slow on me. I am so busy at work, yet I miss OS so much I try to do it in the little free time I have lately.

Can't wait for March when things calm down. (My busiest season is from November to March)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Development

Successfully merging this pull request may close these issues.

list-prs-for-file warns you while you're editing the same PR
2 participants