Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make latest-tag-button more reliable #3947

Merged
merged 1 commit into from Feb 5, 2021
Merged

Make latest-tag-button more reliable #3947

merged 1 commit into from Feb 5, 2021

Conversation

cheap-glitch
Copy link
Member

Thanks for contributing! 馃崉

  1. LINKED ISSUES: -

  2. TEST URLS: Go to a repo homepage (e.g. https://github.com/sindresorhus/refined-github) and hard-refresh a few times.

I noticed this feature failing with an error once in a while (especially when my connection is sluggish). Waiting for the #branch-select-menu element seems to fix it.

@fregante fregante added the bug label Feb 5, 2021
@fregante
Copy link
Member

fregante commented Feb 5, 2021

Makes sense, thank you!

@fregante fregante changed the title Fix latest-tag-button Make latest-tag-button more reliable Feb 5, 2021
@fregante fregante merged commit 4690547 into refined-github:main Feb 5, 2021
@cheap-glitch cheap-glitch deleted the fix-latest-tag-button branch February 5, 2021 20:22
@fregante
Copy link
Member

fregante commented Feb 6, 2021

It looks like this was mentioned in #3673

Does the other 2 feature need a similar treatment?

@cheap-glitch
Copy link
Member Author

cheap-glitch commented Feb 7, 2021

Does the other 2 feature need a similar treatment?

Not from what I can tell.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Development

Successfully merging this pull request may close these issues.

None yet

2 participants