Fix conflict-marker spacing
#4128
Conversation
Co-authored-by: yakov116 <16872793+yakov116@users.noreply.github.com>
|
I didn't notice you had already opened a PR 😅 check out my comment in the original issue, this probably isn't the right solution, especially because we already have a selector that does the exact same thing |
| .rgh-align-issue-labels .js-issue-row .d-inline-block.mr-1 { /* Build status */ | ||
| padding-right: 4px; /* Space before the build status */ | ||
| padding-left: 4px; |
There was a problem hiding this comment.
Why yes both padding and margin though? Is this needed at all? Should the item just have a single mx-2 class?
There was a problem hiding this comment.
This is a pure CSS feature though, is it worth it to add JS just for this?
There was a problem hiding this comment.
Ah indeed I thought that the spacing here was exactly due to the other feature changed in this PR, but instead it's a native icon.
fregante
changed the title
conflict-marker spacing when align-issue-labels is disabledconflict-marker spacing
|
I changed the title because the fix is mostly about doing things right rather than having code that depends on each other. If one day GitHub drops This has the welcome side effect that it helps people who disable features |
Fixes #4117
Test URLs
https://github.com/eslint/eslint/pulls?q=is%3Apr+is%3Aopen+sort%3Aupdated-desc+comments+
Screenshot
With
align-issue-labelsenabled (no change):With
align-issue-labelsdisabled: