Fix releases-tab and bugs-tab
#4169
Conversation
cheap-glitch
changed the title
releases-tab and bugs-tabsreleases-tab and bugs-tab
source/features/bugs-tab.tsx
Outdated
| @@ -87,7 +86,7 @@ async function init(): Promise<void | false> { | |||
| bugsCounter.title = ''; | |||
|
|
|||
| // Update Bugs’ link | |||
| new SearchQuery(bugsLink).add('label:bug'); | |||
| new SearchQuery(bugsTab as HTMLAnchorElement).add('label:bug'); | |||
There was a problem hiding this comment.
Can you drop this type cast once you change the issuesTab selector to a.UnderlineNav-item[data-hotkey="g i"] (i.e. including the tag name a)?
There was a problem hiding this comment.
I thought so too, but unfortunately it seems that cloneNode loses the element type: microsoft/TypeScript#283
There was a problem hiding this comment.
Seems like the workaround added in #2670 doesn't work in this case?
There was a problem hiding this comment.
No it does actually, I just forgot the return value of elementReady() needed to be coerced. My bad.
There was a problem hiding this comment.
There’s an issue open on the element-ready repo to implement the selector parser for types, if anyone is interested. Relatively easy PR for that
|
Looks like it's back to being a list once again xD |
Test URLs
Any repo page
Screenshot
n/a
GitHub changed the layout of the navbar, now it's no longer a list but instead a simple collection of anchor elements. The anchors act both as links and as tabs, so they bear all the meta attributes directly.