Improve error handling for the Safari extension app #4218
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sindresorhus
force-pushed
the
safari-error-handling
branch
from
93ba7e1
to
d426a80
Compare
|
Does this fix or explain #4216? Now that the problem is gone from my computer I can't test it anymore |
|
@fregante It doesn't fix it. But if it happens, it shows the user an error dialog at least. |
|
Was this included in 21.4.12? 😳 Anyway, I'm not a Swift dev, so merge as you see fit |
|
Ugh, no it was not. I'll do another release in a few days then I guess. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I also slightly improved the look of the wrapper app: