Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename collapse-markdown-sections to collapse-wiki-sections #4335

Merged
merged 6 commits into from
May 10, 2021

Conversation

fregante
Copy link
Member

@fregante fregante commented May 9, 2021

The feature is problematic #4144
And not that useful anymore thanks to the native TOC #4244

@fregante fregante requested a review from yakov116 May 9, 2021 12:05
Copy link
Member

@yakov116 yakov116 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@yakov116
Copy link
Member

yakov116 commented May 9, 2021

add "implemented by github" label?

@fregante
Copy link
Member Author

fregante commented May 9, 2021

No, we still have the feature and GitHub did not implement it

@fregante fregante changed the title Disable collapse-markdown-sections everywhere except Wikis Rename collapse-markdown-sections to collapse-wiki-sections May 10, 2021
@fregante fregante merged commit 36a5a73 into main May 10, 2021
@fregante fregante deleted the bye-collapse-markdown-sections branch May 10, 2021 03:44
@yakov116
Copy link
Member

Migration?

@fregante
Copy link
Member Author

We don't need to migrate every feature, especially when the changes are substantial or if it had serious (now resolved) issues that brought people to disable it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants