-
-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enable edit-comments-faster
on Discussions
#4336
Enable edit-comments-faster
on Discussions
#4336
Conversation
parse-backticks
work in Discussionsedit-comments-faster
work in Discussions
edit-comments-faster
work in Discussionsedit-comments-faster
on Discussions
Thanks to yakov116
@@ -14,12 +14,12 @@ function init(): void { | |||
|
|||
comment | |||
.closest('.js-comment')! | |||
.querySelector('.timeline-comment-actions > details:last-child')! // The dropdown | |||
.querySelector('.timeline-comment-actions > details:last-child, .timeline-comment-actions details:last-child')! // The dropdown |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Did you check that this does not make issues in other places. There is probably a reason that we used such a specific selector.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
See #4042 (comment)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I only tested in issues, Discussions (all non-locked) and this PR page.
I don't have any locked conversation URL to have participated in.
As I wrote in the OP, I can only suggest a more specific alternative additional selector:
.timeline-comment-actions > div > details:last-child
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Either way the 2 selectors currently overlap. The first one is unnecessary because the second one already covers that.
@yakov116’s notes still apply
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ok, I kept only the second one. Thank you.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Did you check if locked issues work?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, I tried it in a test repo I have made:
I locked an issue, discussion and PR page, and it works ok in all
(with the selector I kept .timeline-comment-actions details:last-child
).
Co-authored-by: yakov116 <16872793+yakov116@users.noreply.github.com>
Co-authored-by: yakov116 <16872793+yakov116@users.noreply.github.com>
Closes #4334
Test URLs
tophf/mpiv#50
Screenshot
Note to reviewers
.timeline-comment-actions details:last-child
(or.timeline-comment-actions > div > details:last-child
) is for discussions