Enable file-finder-buffer everywhere
#4441
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cheap-glitch
commented
Jun 3, 2021
| @@ -35,7 +35,7 @@ function pjaxStartHandler(event: CustomEvent): void { | |||
| <span className="flex-self-stretch mr-2">{bufferField}</span> | |||
| ); | |||
| bufferField.focus(); | |||
| for (const element of select.all('.pagehead-actions, .rgh-ci-link, .octotree-bookmark-btn')) { | |||
| for (const element of select.all('.pagehead-actions, .rgh-ci-link details, .octotree-bookmark-btn')) { | |||
There was a problem hiding this comment.
Since .rgh-ci-link is applied to the wrapper around the title, this was effectively removing the whole thing (including the inserted buffer).
| @@ -11,7 +11,7 @@ async function init(): Promise<void> { | |||
| <a | |||
| hidden | |||
| data-hotkey="t" | |||
| data-pjax="true" | |||
| data-pjax="#js-repo-pjax-container" | |||
There was a problem hiding this comment.
Setting the data-pjax attribute to true caused the hotkey to trigger a "real" navigation instead of an AJAX one, so the handlers added by file-finder-buffer weren't called.
This is probably because the element is inserted outside the main "container" (as opposed of the native hotkey which is located on the "Go to file" button).
Fixed it by changing the value of the attribute, mimicking the native link in the repo name heading:
<a data-pjax="#js-repo-pjax-container" href="/sindresorhus/refined-github">refined-github</a>But this could also probably be fixed by inserting the link element directly inside the container.
fregante
changed the title
file-finder-buffer should work on the same pages as repo-wide-file-finderfile-finder-buffer everywhere
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #4159
Test URLs
Any repo page, including this one.
Screenshot
capture-1622712596.mp4