Fix for highest rated comment header #4552
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fregante
requested changes
Jul 9, 2021
There was a problem hiding this comment.
I think that we should perhaps try to match the discussion styles, by just changing the border color and then adding that round checkmark icon
Example: vercel/next.js#19409
ghost
requested a review
from 
|
|
Text color as well? Good idea, one moment |
|
@fregante I did as you asked and also added a 👍 indicator. Should I change the |
|
All done for you @fregante:
|
That does not match the style of discussions at all. Sorry, closing. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #4529.
Test URLs
isaacs/github#402 (comment)
vercel/swr#93 (comment)
Screenshot
Before
After