Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix style conflict caused by reactions-avatars on other pages #4635

Merged
merged 1 commit into from
Aug 14, 2021

Conversation

kidonng
Copy link
Member

@kidonng kidonng commented Aug 2, 2021

@kidonng kidonng changed the title Only apply reactions-avatars to implemented pages Only apply reactions-avatars style to implemented pages Aug 2, 2021
@fregante
Copy link
Member

fregante commented Aug 2, 2021

Why not use a more specific selector instead? If GitHub adds reactions to more places we have to add more exceptions. Is there a comments class that doesn't appear on other pages?

@altrisi
Copy link

altrisi commented Aug 2, 2021

Another solution for most of those selectors would be to add a class to reaction avatars so they can be referenced directly instead of relying on them being the only span inside the reaction button.

@fregante
Copy link
Member

fregante commented Aug 2, 2021

Good idea, we can add a class on the button and then target the contents via span and img

@yakov116 yakov116 added the bug label Aug 4, 2021
@fregante fregante changed the title Only apply reactions-avatars style to implemented pages Avoid style conflict caused by reactions-avatars on other pages Aug 4, 2021
@fregante fregante changed the title Avoid style conflict caused by reactions-avatars on other pages Fix style conflict caused by reactions-avatars on other pages Aug 4, 2021
@yakov116 yakov116 marked this pull request as draft August 13, 2021 13:50
@fregante fregante marked this pull request as ready for review August 14, 2021 03:08
@fregante fregante merged commit fd71c47 into refined-github:main Aug 14, 2021
@fregante
Copy link
Member

Merging because it’s a fix but hoping for a better fix later. Tagging it as such 👇

@fregante fregante added the Please! ♥︎ Particularly useful features that everyone would love! label Aug 14, 2021
@kidonng
Copy link
Member Author

kidonng commented Aug 14, 2021

I kinda forgot about this PR. IMO it's specific enough because it seems the discussion and release reactions uses the same "newer" markup and I'd expect any (potential) future additional will be the same.

Or perhaps we just implement reaction-avatars on every page (#3978) 😄

@fregante fregante removed the Please! ♥︎ Particularly useful features that everyone would love! label Aug 18, 2021
kidonng added a commit to kidonng/refined-github that referenced this pull request Aug 28, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Development

Successfully merging this pull request may close these issues.

reactions-avatars style applied to not implemented pages
4 participants