Fix quick-repo-deletion not aborting on Firefox

[cheap-glitch]

Fixes #4599

Test URLs

A fork you own or an empty repo with no stars

Screenshot

capture-1628591720.mp4

Turns out the z-index was not the problem, rather it was the controller that wasn't aborted.
Tested on Firefox only

[fregante]

Can we also just change it to a global click handler as I suggested in the issue? This should just never happen even if in the future z-index is the issue, because in the #4599’s screenshot it definitely is.

[cheap-glitch]

Can we also just change it to a global click handler as I suggested in the issue?

👍

Edit: done and tested both with a normal and a broken z-index

because in the #4599’s screenshot it definitely is.

No, it's just what happens when the <details> element is closed but the controller isn't aborted (because the button style isn't reset properly).

capture-1628684186.mp4

[fregante]

I think we should preserve the previous toggle/abort state sync. The "close on click anywhere" should be on top of that.

Now I see these problems:

• if the user lets it complete, the first click after completion will be ignored, even if they click on the menu
• if the overlay is closed in any way other than click (Enter, esc? Whatever closes the detail), the click might not be caught

The code might not end up super clean since we need several listeners all two-way-linked to an AbortController, but this feature is something we need to take extra care of, perhaps even adding an additional "press any key to stop" listener.

[fregante]

This probably still works better than before. We can publish this in the upcoming version and improve it afterwards.