Fix clean-dashboard’s background color
#4842
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fregante
commented
Oct 1, 2021
| @@ -2,7 +2,7 @@ | |||
| /* 2020-12-15: these variables only exist for GHE #3798 */ | |||
| --github-green: var(--color-text-success, #28a745); | |||
| --github-red: var(--color-text-danger, #cb2431); | |||
| --github-border-color: var(--color-border-primary, #e1e4e8); | |||
| --github-border-color: var(--color-border-muted, #e1e4e8); | |||
There was a problem hiding this comment.
This is also affecting other features. Here's the before/after
fregante
commented
Oct 1, 2021
| @@ -16,7 +16,7 @@ | |||
|
|
|||
| /* Add background and border Whole list */ | |||
| .rgh-clean-dashboard .news > .f4 + div { | |||
| background-color: var(--color-bg-canvas, #fff); | |||
| background-color: var(--color-canvas-default, var(--color-bg-canvas)); | |||
There was a problem hiding this comment.
Also drops the default hardcoded white. Now it will default to transparent instead, which is almost good anyway.
1 task
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
clean-dashboard#4841Test URLs
https://github.com/
Before
## After