-
-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix hide-low-quality-comments
style
#4850
Fix hide-low-quality-comments
style
#4850
Conversation
Hey I implemented this bug 3 years ago or something 😌 I'm proud it almost made it to 2022 |
Might be a good chance to update that red to use a dark-mode-compatible CSS variable from GitHub. Maybe the |
Thanks! We can drop the media query for the 3-color fallback. They're only there to avoid defaulting to transparent, it's fine if they're not perfect in dark mode when missing. They'll actually be useful to show us the variables aren't working. |
It's better we just have a debug mode where it automatically scans for all CSS variables and report missing ones. |
|
||
@media (prefers-color-scheme: dark) { | ||
:root { | ||
--github-red: #f85149; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This can stay I suppose
I've been thinking about setting up automated tests running on GitHub.com with a real user. But it takes a lot of effort to set up and a lot of effort to write tests. I'd rather focus on the bug fixing than writing something that just finds more bugs 😜 |
Fix #4849
NOTE:
highest-rated-comment
got a similar style fix in #4554Test URLs
jerone/UserScripts#1 (comment)
Screenshot
Before:
After: