Fix inconsistent show-names color
#4851
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kidonng
reviewed
Oct 2, 2021
|
You can change the following lines: To: insertionPoint.after(
// That obnoxious part is to comfort the linter
<span className="color-text-secondary">{`${'('}`}
<bdo className="css-truncate css-truncate-target" style={{maxWidth: '200px'}}>
{names[userKey].name}
</bdo>)
</span>,
); |
fregante
reviewed
Oct 3, 2021
fregante
reviewed
Oct 4, 2021
fregante
changed the title
show-names fix inconsistent text colorshow-names color
fregante
approved these changes
Oct 4, 2021
| </bdo>, | ||
| ') ', | ||
| <span className="color-text-secondary css-truncate"> | ||
| (<bdo className="css-truncate-target" style={{maxWidth: '200px'}}>{name}</bdo>) |
There was a problem hiding this comment.
It'd be great to check whether the maxWidth and the insertionPoint logic are still needed as well, but I'll merge this as is for now
|
Dziękuję za pomoc Bartosz |
|
After this PR
|
|
Interestingly, in the comment headers there's a space missing after the name, but in the commit activity entries the space is missing before the name:
|
This was referenced Oct 16, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #4847
Test URLs
#4821 (comment)
Screenshot
Before
After
