Improve reliability of reactions-avatar
#4858
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Does the current solution works permanently? i.e. does it still work if add/remove multiple reactions, across windows? |
Yes |
fregante
changed the title
reactions-avatar featurereactions-avatar
|
Neat! I didn't realized it also fixed #4591 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #4845
Fixes #4591
Test URLs
Screenshot
capture-1633251437.mp4
@fregante feel free to close this if it's not the right solution. I just don't get why
onReplacedElementwas used in the first place, when the tracked element ins't even used in the callback 馃し