-
-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix: Margin missing sometimes in the PR sidebar #4866
Conversation
@@ -9,6 +9,7 @@ | |||
} | |||
|
|||
/* Align the top of the sidebar with the main page content */ | |||
.rgh-clean-repo-sidebar .gutter-condensed > :last-child { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This selector was also affecting the sidebar in PR discussions
The change is reasonable, but the underlying issue probably still remains. Is the differing DOM GitHub’s fault or ours? If it's their fault then this change is 100% fine. |
Checked: It's our fault. Try:
Then try:
|
The underlying "issue" is that the styles from |
Gotchaaaa, it's all because of the class You can just add it to this page and see the issue. Let's fix that instead, CSS should not add to undo, it should only affect what it needs to affect and nothing more (ideally) |
D'oh, that's exactly what you did 😂 🙌 |
Love to see many bugfixes in the upcoming release, which will happen this week. |
Fixes #4642
Test URLs
Steps to reproduce the bug:
Screenshot
capture-1633343624.mp4