Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hide trailing separator in PR and commit files dropdown #5159

Merged
merged 2 commits into from
Dec 7, 2021

Conversation

cheap-glitch
Copy link
Member

Test URLs

Screenshot

Before

screenshot-1638872748

After

screenshot-1638872703

Copy link
Member Author

@cheap-glitch cheap-glitch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems like some users have a "Open on desktop" link at the end of the dropdown — this shouldn't change anything in their case. I don't, so there's just this annoying trailing bar.

I couldn't think of any other dropdowns/menus that could be targeted by this too, but maybe there are.

@fregante

This comment has been minimized.

Copy link
Member

@fregante fregante left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

After moving it to GitHub-bugs

@cheap-glitch cheap-glitch merged commit ff28fa4 into main Dec 7, 2021
@cheap-glitch cheap-glitch deleted the hide-trailing-separators branch December 7, 2021 13:48
fregante added a commit that referenced this pull request Aug 6, 2022
fregante added a commit that referenced this pull request Jul 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

None yet

2 participants