Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prevent patch-diff-links from being AJAXed #5339

Merged
merged 2 commits into from Jan 29, 2022
Merged

Conversation

kidonng
Copy link
Member

@kidonng kidonng commented Jan 27, 2022

PJAX should never enable on these links, yet it does on PR commits page.

Test URLs

https://github.com//refined-github/refined-github/pull/5238/commits/ebf3f1da71aea11782b8586501ec92fbb002316d

Screenshot

N/A

@@ -12,10 +12,10 @@ function init(): void {
}

select('.commit-meta > :last-child')!.append(
<span className="sha-block patch-diff-links">
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Forgotten in #4735

@kidonng kidonng changed the title patch-diff-links skip PJAX Prevent patch-diff-links from being AJAXed Jan 27, 2022
@kidonng kidonng merged commit ecb1769 into main Jan 29, 2022
@kidonng kidonng deleted the patch-diff-links-no-pjax branch January 29, 2022 16:47
@kidonng kidonng added the bug label Feb 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Development

Successfully merging this pull request may close these issues.

None yet

2 participants