Improve reliability of wait-for-build

[cheap-glitch]

Fixes #5336
Hopefully fixes #5023

Test URLs

The feature should NOT run here:

• Draft PR
• Merged PR
• PR on repo with no Actions

Videos

Successful CI

successful.mp4

Failing CI

failing.mp4

[cheap-glitch]

This PR doesn't fundamentally changes how wait-for-build works, but it makes its internals rely on the DOM as little as possible:

1. The checkbox will appear if there's at least one commit with a CI icon, and the icon of the latest commit is either missing or yellow.

2. When the user clicks the merge button, the API will be queried every 5 to 10 seconds (using p-retry).

3. The DOM is watched to cancel the operation, but only in the case of a new commit being pushed.

Also it adds more checks in the feature setup to exclude draft/merged PRs, repo with no workflows and repo with Actions disabled.

[cheap-glitch]

The current mechanism goes like this:

• the DOM observer is (hopefully) triggered when a new commit is pushed
• it enables the merge form again
• up to 10 seconds later, the "API watcher" sees the form has been enabled and stops

This feels needlessly roundabout. Having sindresorhus/p-retry#53 would be a much cleaner solution, so I think I'll work on that next.

[cheap-glitch]

This feels needlessly roundabout. Having https://togithub.com/sindresorhus/p-retry/issues/53 would be a much cleaner solution, so I think I'll work on that next.

Opened sindresorhus/p-retry#59

[cheap-glitch]

While we're at it, how about renaming the feature wait-for-checks or wait-for-ci? "Build" is too specific imo

[fregante]

YOLO

[cheap-glitch]

Follow-up:

• once Support AbortController sindresorhus/p-retry#59 is done, use an AbortController to stop waiting when a new commit is pushed

[kidonng]

I'm not that good at (and into) reviewing but this is simply immeasurable hard work. @cheap-glitch you are a legend

Now if you accept one-time sponsorship...

[cheap-glitch]

Thank you! Now let's hope this doesn't crash and burn 🤞

I'm not that good at (and into) reviewing

Just a quick read-through is still useful, especially on big PRs like this one, as it can help catching slip-ups like this:

refined-github/source/features/wait-for-checks.tsx

Line 118 in 6d5e4d8

console.log('Watching new commits');

(Yes I use console to debug 😳)

Now if you accept one-time sponsorship...

I've enabled it 😉

[kidonng]

Just a quick read-through is still useful, especially on big PRs like this one, as it can help catching slip-ups like this:

LOL but it's fine. Consider it an easter egg and hava fun linting later 😄

(Yes I use console to debug 😳)

I do that too. Browser extension breakpoints are a pain to setup for me.