Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ensure single initialization #554

Merged
merged 1 commit into from
Jun 30, 2017
Merged

Ensure single initialization #554

merged 1 commit into from
Jun 30, 2017

Conversation

fregante
Copy link
Member

@sindresorhus
Copy link
Member

sindresorhus commented Jun 30, 2017 •
edited

@hkdobrev @busches @OmgImAlexis Can you confirm this works around the issue? I'm unable to reproduce the issue in the first place.

@OmgImAlexis
Copy link

Yep that's fixed it. Only one trending shows up now.

@sindresorhus sindresorhus merged commit 696445d into master Jun 30, 2017
@sindresorhus sindresorhus deleted the single-init branch June 30, 2017 15:02
@busches
Copy link
Member

busches commented Jun 30, 2017

We should be able to tear out a lot of duplicate detection code that exists in content.js now with this.

@fregante fregante mentioned this pull request Jul 4, 2017
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@fregante @sindresorhus @OmgImAlexis @busches