Fix sticky-file-header on commits
#5717
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fregante
approved these changes
Jun 23, 2022
|
The only problem is that there's no border between the two headers:
I don’t think this has a straightforward fix, so this PR can be merged before today’s release unless you mark it as draft first |
4 tasks
|
That component has no shadow indeed. The shadow on PRs comes from a standalone component .pr-toolbar.is-stuck {
box-shadow: 0 2px 2px rgba(0, 0, 0, 0.075);
border-bottom: 1px solid rgba(0,0,0,.15)
} |
GitHub does the same on
|
|
|
|
This is still not fixed for me on 22.7.11. |
|
Never mind, I'm still on 22.6.25. Firefox was displaying the version as 22.7.11 before restarting, something wrong with hotfixing maybe? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Broken by GitHub's Pull Request File Tree feature added a while ago.
Test URLs
1d9dd9f
Screenshot
Screen.Recording.2022-06-23.at.01.45.58.mov
I would really like to add kidonng/cherry@997ccdf as well, since that's pretty much the only place left with no sticky file header (and technically speaking, GitHub already enabled it for markup i.e. Markdown files).
P.S. it's funny GitHUb pushed a bug when I'm working on this