Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Restore user-local-time #5721

Merged
merged 2 commits into from
Jun 24, 2022
Merged

Restore user-local-time #5721

merged 2 commits into from
Jun 24, 2022

Conversation

mangkoran
Copy link
Contributor

@mangkoran mangkoran commented Jun 24, 2022 •
edited

Test URLs

(In case its you that viewing the PR, I put several accounts here)

Screenshot

image

@mangkoran
Fix user-local-time not showing
6dd5b66 
Change parent element selector. Change username hyperlink element
selector as `Link--primary` only used by username in the hovercard. Also
update this element style (using `address` as reference).
@mangkoran
Copy link
Contributor Author

A bit out of context, but how this feature works? Sometimes I can see the local time, sometimes not (disregarding this issue)?

fregante
fregante approved these changes Jun 24, 2022
View reviewed changes
Copy link
Member

@fregante fregante left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mantap!

@fregante
Copy link
Member

I confirm it works:

Screen Shot

how this feature works

Commits include your timezone, so we fetch the user’s "github event" until we find the latest commit. If a user hasn't pushed in a while or hasn't pushed at all, the feature won't work.

@yakov116
Copy link
Member

Will this break GHE?

@fregante fregante changed the title Fix user-local-time not showing Restore user-local-time Jun 24, 2022
@fregante fregante merged commit d17b766 into refined-github:main Jun 24, 2022
@fregante fregante added the bug label Jun 24, 2022
@mangkoran
Copy link
Contributor Author

mangkoran commented Jun 25, 2022 •
edited

Thank you for the amendment. I have no idea it will break GHE (I have no idea that GHE is different either). Glad to be able to contribute to RGH :D

@cheap-glitch
Copy link
Member

I have no idea that GHE is different either

GHE = GitHub Enterprise. If I'm not wrong it's basically separate versions of GitHub that run on private company servers, which means they're always lagging behind in term of updates. So we also have to support (up to a point) "older versions" of GitHub.

Glad to be able to contribute to RGH

Thank you for your help! We have a bunch of easy issues if you feel like contributing again 😉

https://github.com/refined-github/refined-github/issues?q=is%3Aissue+is%3Aopen+sort%3Aupdated-desc+label%3A%22good+first+issue%22

@fregante fregante mentioned this pull request Jul 3, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fregante fregante fregante approved these changes

Assignees
No one assigned
Labels
bug
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

user-local-time not working
4 participants
@mangkoran @fregante @yakov116 @cheap-glitch