Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

use-first-commit-message-for-new-prs Support formatted commits #5736

Merged
merged 8 commits into from
Jul 1, 2022
Merged

use-first-commit-message-for-new-prs Support formatted commits #5736

merged 8 commits into from
Jul 1, 2022

Conversation

fregante
Copy link
Member

@fregante fregante commented Jun 28, 2022 •
edited

@fregante
Copy link
Member Author

Screen Shot 16

@fregante fregante marked this pull request as ready for review June 28, 2022 11:20
@fregante fregante changed the title Support issue refs and emojis in use-first-commit-message-for-new-prs use-first-commit-message-for-new-prs Support formatted commits (#5736) Jun 28, 2022
@fregante fregante changed the title use-first-commit-message-for-new-prs Support formatted commits (#5736) use-first-commit-message-for-new-prs Support formatted commits Jun 28, 2022
@fregante
Copy link
Member Author

fregante commented Jun 29, 2022 •
edited

Can you think of any other situation that might be rendered?

Anyway, there's still one small issue 😰 see the ellipsis in https://github.com/refined-github/sandbox/compare/github-moji?expand=1

Screen Shot 14

@fregante fregante marked this pull request as draft June 29, 2022 16:03
@fregante fregante marked this pull request as ready for review July 1, 2022 12:21
@fregante
Copy link
Member Author

fregante commented Jul 1, 2022

Screen Shot 10

@fregante fregante merged commit 587c232 into main Jul 1, 2022
@fregante fregante deleted the first-commit branch July 1, 2022 12:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yakov116 yakov116 yakov116 left review comments

Assignees
No one assigned
Labels
bug
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Emojis in commit title breaks use-first-commit-message-for-new-prs
3 participants
@fregante @yakov116 @cheap-glitch