Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix duplication of features on first load #5742

Merged
merged 1 commit into from
Jun 29, 2022

Conversation

fregante
Copy link
Member

@fregante fregante commented Jun 29, 2022

Here's the sequence again:

Screen Shot

Generated via

['turbo:before-cache',
'turbo:before-fetch-request',
'turbo:before-fetch-response',
'turbo:before-render',
'turbo:before-stream-render',
'turbo:before-visit',
'turbo:click',
'turbo:frame-load',
'turbo:frame-render',
'turbo:load',
'turbo:reload',
'turbo:render',
'turbo:submit-end',
'turbo:submit-start',
'turbo:visit',
'pjax:start',
'pjax:end',
'pjax:complete',
'pjax:error',].map(x => document.addEventListener(x, e => console.log(x)))

@fregante fregante changed the title Use turbo:render for ajaxed events Fix duplication of features Jun 29, 2022
@fregante fregante marked this pull request as ready for review June 29, 2022 04:50
@fregante fregante merged commit 10d5754 into main Jun 29, 2022
@fregante fregante deleted the brand-new-ajax-with-50%-less-runs branch June 29, 2022 05:29
@fregante fregante added the ajax Temporary label to collect Ajax issues label Jun 29, 2022
@fregante fregante changed the title Fix duplication of features Fix duplication of features on first load Jul 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ajax Temporary label to collect Ajax issues bug
Development

Successfully merging this pull request may close these issues.

Some HTML elements get inserted twice
2 participants