Fit large images in the window when viewing single files #5754
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you! This doesn't affect images in commits, which is good 👍 4218456#diff-f44b12b0416bb268cf2491ea46a5f8deae4823068722a5bfcc61d0f87d371169 |
|
It only limits the max size of images, it shouldn't affect any images that are smaller. |
fregante
reviewed
Jun 29, 2022
There was a problem hiding this comment.
Related link with potentially more cases to test or ignore https://docs.github.com/en/repositories/working-with-files/using-files/working-with-non-code-files
fregante
changed the title
Co-authored-by: Federico Brigante <me@fregante.com>
|
CSS only runs on blob image previews because of |
fregante
approved these changes
Jun 29, 2022
cheap-glitch
approved these changes
Jun 30, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #5740
Adds the following css to restrict image blob sizes:
Test URLs
https://github.com/KatsuteDev/Mal4J/blob/main/assets/banner-sq.png
Screenshot