Fix duplication of features on back/forward button click #5761
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fregante
commented
Jul 1, 2022
| @@ -324,7 +324,7 @@ void add('rgh-deduplicator' as FeatureID, { | |||
| // `await` kicks it to the next tick, after the other features have checked for 'has-rgh', so they can run once. | |||
| await Promise.resolve(); | |||
| select('#js-repo-pjax-container, #js-pjax-container')?.append(<has-rgh/>); | |||
| select('#repo-content-pjax-container')?.append(<has-rgh-inner/>); // #4567 | |||
| select('#repo-content-pjax-container, turbo-frame')?.append(<has-rgh-inner/>); // #4567 | |||
There was a problem hiding this comment.
I found that turbo-frame contains #repo-content-pjax-container on the first load and then it's gone. Select will return the first element matching the selector, which is always turbo-frame since it's the parent
fregante
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#repo-content-pjax-containeris gone #5751Test