-
-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add jump-to-conversation-close-event
feature
#5794
Conversation
Missing |
constructor: HTMLSpanElement, | ||
add(messageContainer) { | ||
messageContainer.classList.add('rgh-jump-to-conversation-close-event'); | ||
// Hide the native title |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@fregante is this a good idea? We cannot modify the title since that is our detection, but I don't want the title "Status: Closed" tooltip to show.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I agree that it's not particularly useful, but let's not mess with it
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It gets in the way of the other tooltip
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you extend the comment explaining why we need to leave the title attribute, why we can鈥檛 modify it, and why it needs to be hidden at all?
The current comment only explain what it鈥檚 doing but not why
Thanks! I moved, my computer broke and things just did not settle down until now. |
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
Co-authored-by: Flo Edelmann <florian-edelmann@online.de>
Note this will fail on big PR such as #1986 But see #3813 (comment) so I don't see an issue |
This comment was marked as resolved.
This comment was marked as resolved.
Co-authored-by: Federico Brigante <me@fregante.com>
Co-authored-by: Federico Brigante <me@fregante.com>
Co-authored-by: Federico Brigante <me@fregante.com>
My first add feature PR in a year! Last one was #4534. 馃帀
Closes #4773
Test URLs
Closed Issue: refined-github/sandbox#24
Closed Issue (Not Planned): refined-github/sandbox#2
Merged PR: refined-github/sandbox#23
Closed PR: refined-github/sandbox#22
Screenshot