Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't add workflow count in clean-repo-tabs #5806

Merged
merged 1 commit into from
Jul 11, 2022
Merged

Conversation

fregante
Copy link
Member

@fregante fregante commented Jul 8, 2022

I was going to suggest a feature to drop this count when I realized we're adding it.

I don't find it particularly useful and it appears to be noise.

Drop?

Before

Screen Shot 4

After

Screen Shot 5

@yakov116
Copy link
Member

yakov116 commented Jul 8, 2022

I use it all the time to download from actions the latest zip or artifact.

Also useful for people that have manual actions.

Don't think we should hide it.

@fregante
Copy link
Member Author

fregante commented Jul 8, 2022

This removes the count, not the tab. I should have added the screenshots 😅

@fregante fregante changed the title Don't add a workflow count to the actions tab in clean-repo-tabs Don't add workflow count in clean-repo-tabs Jul 8, 2022
@fregante
Copy link
Member Author

fregante commented Jul 8, 2022

I'd honestly also remove the wiki page count, but that's slightly more useful. We already hide the tab when empty so technically clean-repo-tabs would do its dirty job even without the counter.

@cheap-glitch
Copy link
Member

I'm -0 on this. I think it's nice to have, but I agree it's not that useful since workflows can be very simple just like they can be extremely complex, so that number doesn't really convey much information.

@kidonng
Copy link
Member

kidonng commented Jul 9, 2022

I think we added it to be consistent with e.g. issue and PR count.

I would proceed to argue wiki count (and even release count) aren't that important either.

EDIT: oops, didn't see #5806 (comment)

@fregante fregante merged commit 8c5a0d0 into main Jul 11, 2022
@fregante fregante deleted the no-actions-count branch July 11, 2022 13:02
@fregante
Copy link
Member Author

I think for now I'll just drop the actions count. I think a 2+ wiki count is still useful to distinguish "Welcome to the wiki"-only dead wikis from useful ones.

@fregante fregante added the bug label Jul 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Development

Successfully merging this pull request may close these issues.

None yet

4 participants