Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Only run useful-forks on public repositories #5853

Merged
merged 2 commits into from
Aug 16, 2022

Conversation

kidonng
Copy link
Member

@kidonng kidonng commented Jul 26, 2022

Waiting for refined-github/github-url-detection#140

At times like this I want to npm install refined-github/github-url-detection#isPublicRepo and chill

Test URLs

https://github.com/username?tab=repositories&type=private

Screenshot

@fregante
Copy link
Member

I mean… where did this bother you? Why archive a private repo in the first place? 😅 I’d place this in the lint PR if you reeeeally want to make this change.

@kidonng
Copy link
Member Author

kidonng commented Jul 26, 2022

I mean… where did this bother you? Why archive a private repo in the first place?

But they are for different usages. Private means "I don't want to show it" and Archived means "Don't bother with it anymore". If I run a script or install a integration for all my repositories, surely I will want to skip archived repos instead of manually excluding them every time.

I’d place this in the lint PR if you reeeeally want to make this change.

Then consider this pull request "Skip some features on private repositories". I will merge it to the lint PR if I don't find anything else worth changing.

@tyrann0us
Copy link
Contributor

I mean… where did this bother you? Why archive a private repo in the first place? 😅 I’d place this in the lint PR if you reeeeally want to make this change.

We are a web (WordPress) agency and there are multiple reasons why we need to archive a private repository:

  1. Discourage usage of reusable, but highly outdated (in terms of code quality) packages
  2. Discourage usage of reusable packages which no longer have a purpose, e.g. fix has landed upstream (WordPress)
  3. If a client cancells SLA, we offboard them and archive all client-specific repositories (which are private)

To give you some numbers, we currently have ~1400 repositories.

  • Public: ~60
  • Private ~1300
  • Archived: ~450
  • Private archived: ~430 of the ~450

So TL;DR, for us it would make much sense to not show the useful forks link for private archived repositories.
Thanks!

@fregante fregante changed the base branch from main to if-at-first-you-don't-succed-lint-again August 16, 2022 06:44
@fregante fregante marked this pull request as ready for review August 16, 2022 06:44
@kidonng
Copy link
Member Author

kidonng commented Aug 16, 2022

@tyrann0us thanks for sharing your experience! I will admit I haven't do active searching of what other features may not be useful on private repos yet 😴 (I don't have that many, to begin with). We would be happy to hear it if you noticed more of them.


Since bumping github-url-detection here breaks other features, I will do it in the lint PR.

@kidonng kidonng merged commit c39f9ce into if-at-first-you-don't-succed-lint-again Aug 16, 2022
@kidonng kidonng deleted the useful-forks branch August 16, 2022 07:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

None yet

3 participants