Support "For you" feed in infinite-scroll
#5919
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fregante
approved these changes
Aug 19, 2022
|
It works. The two buttons are always in the DOM once loaded, so listeners are only added once. |
kidonng
commented
Aug 19, 2022
source/features/infinite-scroll.tsx
Outdated
Comment on lines
32
to
34
| observe('.ajax-pagination-btn', button => { | ||
| inView.observe(button); | ||
| }); |
There was a problem hiding this comment.
This can be two element-ready calls instead, but our selector-observer is so lightweight 😆
There was a problem hiding this comment.
Just realized yet another limitation of animations: they don't start when the tab is hidden.
This is the same rAF limitation described here:
There was a problem hiding this comment.
You have stated it here: #5886 (comment)
It's fine in this case, we don't need to load a hidden tab.
fregante
reviewed
Aug 19, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolve #5716
Test URLs
https://github.com/
Screenshot
Screen.Recording.2022-08-19.at.16.44.39.mov