Fix set-default-repositories-type-to-sources on project views

[chcamiloam]

Closes #5940

Test URLs

https://github.com/users/janpio/projects/3/views/1

Screenshot

Description

The error was produces by a selector trying to find an item that doesn't exists in the page.

Changes

The method was doing reference to the user's profile dropdown using the :last-child selector, looks like later a new item was added turning the user's profile item in the second last item. This PR change the selector to select the profile dropdown again.

[fregante]

Thank you for the PR! Doesn't this break it on every other page where the current selector works?

[chcamiloam]

I think we need a validation to only use the new selector in this page, it is not breaking anything but is generating console errors in other pages.
I would like to use Github-url-detection to track this page too. I sent this PR to that repo refined-github/github-url-detection#149 To add the projects/views route to the detection package. Once it is merged I'll send the update to this PR, if you think there is another way to add the validation I'll happy to try it.

[fregante]

I think it doesn't need a per-page selector. We can fix it by using a different selector that doesn't involve nth-child.

[fregante]

Actually I think this whole file can be replaced by our selector-observer.ts (not to be confused with the library with we also still use)

Instead of having a custom onProfileDropdown event, we can use the observer to target whichever link we need in the drop-down.

Would you like to give that a try? If not, I will.

Example:

refined-github/source/features/set-default-repositories-type-to-sources.tsx

Lines 14 to 17 in d0491bd

	async function profileDropdown(): Promise<void> {
	await onProfileDropdownLoad();
	addSourceTypeToLink(select('.header-nav-current-user ~ a[href$="tab=repositories"]')!); // "Your repositories" in header dropdown
	}

should be something like:

observe('.header-nav-current-user ~ a[href$="tab=repositories"]', addSourceTypeToLink)

[chcamiloam]

Let me check how it works, I'll try with the observer, also I was checking other options, looks like the item we are looking for have this unique mix of clases .position-relative.Header-item.mr-0 at it works perfectly, but let me try the observer

[fregante]

Sure. Once you get it working, you can refer to how it's generally used. For example:

• it should accept a {signal} parameter (see how that works in other features the use selector-observer.ts)
• it should not use onetime in the definition (which it currently does)

[fregante]

Fantastic!

[chcamiloam]

Type=source is added to the URL and no errors in the console.

We could add some pre-commits here 😅

[fregante]

We could add some pre-commits here 😅

Linting and testing is slow, post-commits are better in this case. 😜 You wouldn't want to run the whole suite every time you make a single commit

[fregante]

Thank you for your contribution!

[janpio]

Thank you indeed!