Fix quick-review-comment-deletion
#5970
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yakov116
changed the title
quick-review-comment-deletion
fregante
reviewed
Sep 13, 2022
| @@ -33,7 +33,7 @@ function init(signal: AbortSignal): Deinit { | |||
| delegate(document, '.rgh-review-comment-delete-button', 'click', onButtonClick, {signal}); | |||
| delegate(document, '.rgh-quick-comment-edit-button', 'click', onEditButtonClick, {signal}); | |||
|
|
|||
| return observe('.review-comment > .unminimized-comment form:not(.js-single-suggested-change-form) .js-comment-cancel-button:not(.rgh-delete-button-added)', { | |||
| return observe('.review-comment form.js-comment-update:not(.js-single-suggested-change-form) .js-previewable-comment-form .form-actions .js-comment-cancel-button:not(.rgh-delete-button-added)', { | |||
There was a problem hiding this comment.
Thanks for the PR!
I think this selector can be greatly shortened now. In this specific instance, the issue was just > .unminimized-comment, so dropping it would already fix it.
Better yet, probably this:
.review-comment .js-comment-cancel-button:not(.rgh-delete-button-added)But it needs testing to ensure it doesn't also apply to unrelated parts. You an add a console.log inside addDeleteButton to see what's being matched exactly.
Context:
- For example,
.js-single-suggested-change-formwas added in 5edc743, but it doesn't apply anymore.
ཐུགས་རྗེ་ཆེ་ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #5901
Test URLs
https://github.com/refined-github/refined-github/pull/5899/files
Screenshot