Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Disable sticky-sidebar on small viewports #5985

Merged
merged 1 commit into from
Sep 15, 2022
Merged

Disable sticky-sidebar on small viewports #5985

merged 1 commit into from
Sep 15, 2022

Conversation

fregante
Copy link
Member

Test

  1. On this PR or on https://github.com/refined-github/refined-github
  2. Resize window to less than 768px in width OR use a phone
  3. There should not be a rgh-sticky-sidebar class when the sidebar is below the content

Note: pop the developer tools out so they don't affect the viewport height calculations

@fregante fregante added the bug label Sep 15, 2022
@fregante fregante merged commit 4fe15e0 into main Sep 15, 2022
@fregante fregante deleted the no-sticky-mobiles branch September 15, 2022 10:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
bug
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

sticky-sidebar breaks dropdowns on small viewports
1 participant
@fregante