Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoid triggering pr-branch-auto-delete when simply watching a PR #5986

Merged
merged 3 commits into from
Sep 15, 2022

Conversation

fregante
Copy link
Member

@fregante fregante commented Sep 15, 2022

Test

Any PR:

  • that you can merge
  • on a repo without native branch auto-deletion

Test bugfix

  1. Open the PR in two browser, one with RG, one without
  2. Merge the PR in the browser without RG
  3. The branch should not be deleted

Test feature

  1. Merge the PR
  2. The branch should be deleted

@fregante fregante added the bug label Sep 15, 2022
deduplicate: false,
init() {
void addReleaseBanner();
},
Copy link
Member Author

@fregante fregante Sep 15, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I thought this feature was affected because it relied on the old behavior, but not really.

However it would greatly benefit from being rewritten with the new observer instead of using additional listeners, also because we have two separate UI pieces, one of which needs to be applied multiple times.

Related:

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@fregante fregante marked this pull request as ready for review September 15, 2022 10:06
@fregante fregante merged commit c7618ff into main Sep 15, 2022
@fregante fregante deleted the no-spontaneous-deletion branch September 15, 2022 10:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Development

Successfully merging this pull request may close these issues.

pr-branch-auto-delete also deletes branch if it was not merged by the user
1 participant