Restore quick-review-comment-deletion
#6018
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fregante
commented
Sep 25, 2022
| @@ -2,7 +2,7 @@ import select from 'select-dom'; | |||
| import oneEvent from 'one-event'; | |||
|
|
|||
| export default async function loadDetailsMenu(detailsMenu: HTMLElement): Promise<void> { | |||
| const fragment = select('include-fragment.SelectMenu-loading', detailsMenu); | |||
| const fragment = select('.js-comment-header-actions-deferred-include-fragment', detailsMenu); | |||
There was a problem hiding this comment.
They changed classes, so if the user never hovered the dropdown for it to preload it, the action would just silently fail
| add: addDeleteButton, | ||
| }); | ||
| delegate(document, '.rgh-quick-comment-edit-button', 'click', preloadDropdown, {signal}); | ||
| observe('.review-comment .js-comment-cancel-button', addDeleteButton, {signal}); |
| .click(); | ||
| } catch (error) { | ||
| void showToast(new Error('Feature broken. Please open an issue with the link found in the console')); | ||
| features.log.error(import.meta.url, (error as Error).message) |
There was a problem hiding this comment.
Might as well make future errors loud
|
Merging because #6006 somewhat depends on this |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Test URLs
This PR
Screenshot