Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable broken one-click-diff-options on GitHub Enterprise #6040

Merged
merged 1 commit into from
Oct 3, 2022

Conversation

fregante
Copy link
Member

@fregante fregante commented Oct 3, 2022

The feature actively breaks GitHub’s UI on Enterprise, so I had to disable it there. An actual bugfix would be ideal.

@ELLIOTTCABLE @nicolasff @busches

@fregante fregante added bug enterprise Related to GitHub Enterprise only labels Oct 3, 2022
@fregante fregante merged commit 05c85ce into main Oct 3, 2022
@fregante fregante deleted the one-click-diff-optionss branch October 3, 2022 08:06
@busches
Copy link
Member

busches commented Oct 3, 2022

What version is it broken on? It was working on Friday for the latest GHE.

@fregante
Copy link
Member Author

fregante commented Oct 3, 2022

See #5820 (comment)

It felt like too much of a breaking to leave it unfixed. It can be restored on GHE when it's past our support window, or when the selector is updated by someone on GHE.

@busches
Copy link
Member

busches commented Oct 4, 2022

I'm on 3.6 series and it's working fine there. 3.3 series is likely supported through December, unsure of when they changed the markdown to the new layout.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug enterprise Related to GitHub Enterprise only
Development

Successfully merging this pull request may close these issues.

None yet

2 participants