-
-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Meta: Attach built extension to releases #6084
Conversation
Signed-off-by: Moritz Wiesinger <moritz.wiesinger@dynatrace.com>
Not by a computer to test. Are you attaching the refined-github.zip file to the release? |
Could you please be more specific? I didn't find a zip archive that's generated somewhere already. I suppose you mean that the bundle files in |
I think this is right already, what's the issue? The filename? |
I think so |
Sure, I can change it to a zip with your mentioned name @yakov116 |
Signed-off-by: Moritz Wiesinger <moritz.wiesinger@dynatrace.com>
Thank you @mowies! Looking forward to more PRs like this |
It worked (after a quick fix) but manifest.json had the version set to 0.0.0 😕 I removed the attachment: |
I opened #6114 but I don't have time to test it right now. Feel free to try and open a new PR based on it if you'd like |
This PR
distribution
folder created bynpm test
to the created releasedistribution
folder into a tarball before attaching to the releaseCloses #4595