Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Meta: Attach built extension to releases #6084

Merged
merged 4 commits into from
Oct 16, 2022

Conversation

mowies
Copy link
Contributor

@mowies mowies commented Oct 13, 2022

This PR

  • attaches the distribution folder created by npm test to the created release
  • archives the distribution folder into a tarball before attaching to the release

Closes #4595

Signed-off-by: Moritz Wiesinger <moritz.wiesinger@dynatrace.com>
@mowies mowies marked this pull request as ready for review October 13, 2022 11:46
@yakov116
Copy link
Member

Not by a computer to test. Are you attaching the refined-github.zip file to the release?

@yakov116 yakov116 changed the title Attach distribution archive to release Meta: Attach distribution archive to release Oct 13, 2022
@mowies
Copy link
Contributor Author

mowies commented Oct 13, 2022

@yakov116 Nope, I'm just attaching whatever gets generated by npm test into the distribution/ folder as a tar.gz archive.
That's what was asked for in the issue here: #4595

@yakov116
Copy link
Member

@yakov116 Nope, I'm just attaching whatever gets generated by npm test into the distribution/ folder as a tar.gz archive.
That's what was asked for in the issue here: #4595

I think there is a misunderstanding.

We need the refined-github.zip as a separate attachment.

@mowies
Copy link
Contributor Author

mowies commented Oct 13, 2022

Could you please be more specific? I didn't find a zip archive that's generated somewhere already. I suppose you mean that the bundle files in distribution get zipped into refined-github.zip?

@fregante
Copy link
Member

fregante commented Oct 13, 2022

I think this is right already, what's the issue? The filename?

@yakov116
Copy link
Member

I think this is right already, what's the issue? The filename?

I think so

@mowies
Copy link
Contributor Author

mowies commented Oct 13, 2022

Sure, I can change it to a zip with your mentioned name @yakov116

Signed-off-by: Moritz Wiesinger <moritz.wiesinger@dynatrace.com>
@fregante fregante changed the title Meta: Attach distribution archive to release Meta: Attach built extension to releases Oct 14, 2022
@fregante fregante added the meta Related to Refined GitHub itself label Oct 15, 2022
@fregante fregante merged commit 4228f42 into refined-github:main Oct 16, 2022
@fregante
Copy link
Member

Thank you @mowies! Looking forward to more PRs like this

@fregante
Copy link
Member

It worked (after a quick fix) but manifest.json had the version set to 0.0.0 😕 I removed the attachment:

refined-github-local-install.zip

@fregante
Copy link
Member

I opened #6114 but I don't have time to test it right now. Feel free to try and open a new PR based on it if you'd like

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
meta Related to Refined GitHub itself
Development

Successfully merging this pull request may close these issues.

Include artifact in release workflows
3 participants