Reduce table-input CPU usage thanks to :has selector
#6088
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fregante
commented
Oct 16, 2022
source/features/table-input.css
Outdated
| @@ -6,18 +6,33 @@ | |||
| grid-template: repeat(5, 20px) / repeat(5, 20px); | |||
| } | |||
|
|
|||
| :root .rgh-table-input-cell { | |||
| .rgh-table-input .sentinel { /* 🤷♂️ */ | |||
| display: none; | |||
There was a problem hiding this comment.
Did they add this element literally just now while I was writing this PR? I think this effectively forces me to push another release soon because the feature looks wonky 🤔
There was a problem hiding this comment.
They dropped it. What a coincidence.
This reverts commit 61d89ed.
|
Feature verified both in Chrome and Firefox |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
mouseenterevents are triggered hundreds of times just by moving the mouse across the page, whether you’re usingtable-inputor not;delegatewill callquerySelectorin each event to determine whether to call our callback on the specific events we want.Thankfully
:hasagain comes to the rescue, even though the code is awful. I implemented this in a way to preserve backwards compatibility.Test URLs
This page
Screenshot