Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix releases-tab count #6131

Merged
merged 1 commit into from
Nov 3, 2022
Merged

Fix releases-tab count #6131

merged 1 commit into from
Nov 3, 2022

Conversation

yakov116
Copy link
Member

@yakov116 yakov116 commented Nov 3, 2022

Fix #6130

I did not blame this yet. There must have been a reason we did it like this

Assuming this did not exist in the past

Test URLs

https://github.com/refined-github/refined-github

Screenshot

@yakov116 yakov116 added the bug label Nov 3, 2022
@fregante
Copy link
Member

fregante commented Nov 3, 2022

There must have been a reason we did it like this

Yes. The /releases page would also show tags, so even with 0 "github releases", the page would not be empty. This changed in the last 12 months: tags are no longer shown among releases

@yakov116 yakov116 merged commit f047968 into main Nov 3, 2022
@yakov116 yakov116 deleted the yakov116-patch-1 branch November 3, 2022 15:39
@yakov116
Copy link
Member Author

yakov116 commented Nov 4, 2022

Looks like I missed the fetch from dom part. That is looking at the tags.

Can I know why we even are taking from the dom this is a tiny request and we do not do this anywhere else if I am not mistaken

The problem is that we are removing the count in another feature

@fregante
Copy link
Member

fregante commented Nov 4, 2022

We’ve had this issue many times: avoid API vs have multiple sources. Sometimes I rejected the changes sometimes I approved them.

If you’re referring to the tag count on the repo home, you can still use the releases count in the sidebar. In the feature that removes it, we can change it too .hidden = true and leave a comment

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Development

Successfully merging this pull request may close these issues.

releases-tab count is wrong (includes tags)
2 participants