Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Avoid duplicate open-all-notifications buttons #6160

Merged
merged 2 commits into from
Nov 14, 2022
Merged

Avoid duplicate open-all-notifications buttons #6160

merged 2 commits into from
Nov 14, 2022

Conversation

fregante
Copy link
Member

@fregante fregante commented Nov 14, 2022 •
edited

The screenshots below lack a "back button" demo gif but it was also tested and it works.

Test URLs

https://github.com/notifications after clicking "Group by repository"

Grouped

Screen Shot

Grouped and selected

Screen Shot

@fregante fregante added the bug label Nov 14, 2022
@fregante fregante marked this pull request as ready for review November 14, 2022 05:46
@fregante fregante merged commit 638fa69 into main Nov 14, 2022
@fregante fregante deleted the notifications-deduplicate branch November 14, 2022 05:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
bug
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

"Open Unread" duplicates when going back and forth
1 participant
@fregante