Add unhide-reactions-on-mobile feature
#6182
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jtagcat
force-pushed
the
unhide-reactions-on-mobile
branch
from
0854b55
to
05dd6fc
Compare
yakov116
changed the title
unhide-reactions-on-mobileunhide-reactions-on-mobile feature
fregante
requested changes
Dec 4, 2022
There was a problem hiding this comment.
I added a
h4 { color red; }as an initial test. WithisIssueOrPRList, it should not affect the login page..?
I just remembered why. All CSS is always imported. For addCssFeature to work, you have to use .rgh-* in every selector. Refer to other features that use addCssFeature
But in this case we don't need this at all, it's a small CSS bugfix that does not need to be "disableable".
Changes required:
- Delete .tsx file
- Import .css in refined-github.ts and move it to the right place
- Probably revert the changes to the readme as well if CI fails
jtagcat
force-pushed
the
unhide-reactions-on-mobile
branch
from
05dd6fc
to
6437e12
Compare
fregante
approved these changes
Dec 4, 2022
|
Tested (again) working on a mobile device. |
|
Love your screenshot by the way. Are there other features hidden on mobile that you find useful? I think I always need something else but never open an issue when I do 😳 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #6161
Test URLs
#6161
Firefox users have to set
layout.css.has-selector.enabledto true inabout:config(https://developer.mozilla.org/en-US/docs/Web/CSS/:has#browser_compatibility).Screenshot
Tested
On Google Play Store version of Firefox Nightly for Developers, version
109.0a1.With
npx web-ext run -t firefox-android --adb-device <use adb devices> --firefox-apk org.mozilla.fenix