Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Drop clean-dashboard feature #6191

Merged
merged 2 commits into from
Dec 12, 2022
Merged

Drop clean-dashboard feature #6191

merged 2 commits into from
Dec 12, 2022

Conversation

fregante
Copy link
Member

@fregante fregante commented Dec 12, 2022 •
edited

I don’t think it's worth iterating on this feature anymore. The DOM structure is inconsistent and they keep dropping classes. The actual improvement is minimal and at this point I don't care to preserve it as is.

A PR is welcome anytime to reintroduce some improvements as clean-newsfeed but they have to be minimal and tested

Related

yakov116
yakov116 approved these changes Dec 12, 2022
View reviewed changes
Copy link
Member

@yakov116 yakov116 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Agree, its just so sad that we have to drop these after so many years.

@fregante fregante changed the title Drop clean-dashboard Drop clean-dashboard feature Dec 12, 2022
@fregante fregante merged commit 5c51d4e into main Dec 12, 2022
@fregante fregante deleted the drop-clean-dashboard branch December 12, 2022 17:17
@fregante fregante mentioned this pull request Jan 31, 2023
Closed
@fregante fregante mentioned this pull request Mar 14, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yakov116 yakov116 yakov116 approved these changes

@cheap-glitch cheap-glitch Awaiting requested review from cheap-glitch

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

clean-dashboard is a little broken
2 participants
@fregante @yakov116