Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop align-repository-header feature #6247

Merged
merged 1 commit into from
Feb 1, 2023
Merged

Conversation

fregante
Copy link
Member

Why:

  • Maybe it's not such a bad idea to align it left
  • The site header is already aligned left
  • We still aligned left on full-width pages, so RG was making the header switch between the two positions on navigation
  • It seems to be hard to target at the moment, I don't see the full-width class anymore
  • Aligning it to the left means that the repo nav now has more space to show its tabs, which means less nav overflow

cc @szmarczak due to #3280

Test URLs

See previous URLs on #3322

@yakov116
Copy link
Member

I'll miss this one.
But

It seems to be hard to target at the moment, I don't see the full-width class anymore

This i think is the bummer

@yakov116
Copy link
Member

yakov116 commented Feb 1, 2023

Wow I really miss this 😢

@IceSentry
Copy link

IceSentry commented Feb 4, 2023

I don't understand why this change was done. It is a bad idea to align it to the left. What's wrong with things being in the center where the entire content is?

Is there any way to restore this feature? As someone with an ultrawide, having those headers all the way to the left is really annoying to use now.

image

Edit: I just copied the css as is in an extension to inject css and it worked without issues. This works, but now I'll need to do that on every browser I use.

@fregante
Copy link
Member Author

fregante commented Feb 4, 2023

I also liked it before but… see #6229 for the reason why. Also I wrote a lot in the first comment here.

You can also judge by the amount of linked issues before your comment by just how many people didn't like it.

As someone with an ultrawide

Why are you using websites fullscreen on an ultra wide? No website looks good like that. It's a complete waste of screen anyway.

I'll need to do that on every browser I use.

If they're all Chrome under the same Google account, they're automatically synchronized in Refined GitHub.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

align-repository-header should be disabled on new file/folder views
3 participants