Restore copy-on-y and enable it on every page
#6252
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yakov116
approved these changes
Jan 30, 2023
| const url = location.href; | ||
| await navigator.clipboard.writeText(url); | ||
| // Log to ensure we're coping the new URL | ||
| console.log('Copied URL to the clipboard', url); |
There was a problem hiding this comment.
Yes for now:
- could be helpful if suddenly this starts copying the non-permalinked URL
- we're not giving any feedback that this feature is doing anything
- the log only appears in rare situations, i.e. when the user does tap Y
There was a problem hiding this comment.
Why not use the logger function?
There was a problem hiding this comment.
Laziness to check how that worked 😂
Will do 🚀
There was a problem hiding this comment.
We don't seem to use features.log.info anywhere except "show features that are run on the page", it doesn't seem strictly related to this type of logging. Given this is user feedback, I'd still keep it here unconditionally
Not in this instance, the filter was always here: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
copy-on-ybroken #6210Over the years I've come to expect "copy on y" on any page so I think it wouldn't be too bad to actually enable it site-wide.
Thoughts?

Test URLs
Literally any page, including:
https://github.com/refined-github/refined-github/blob/main/source/features/hide-diff-signs.css