Remember one-click-diff-options state
#6261
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fregante
commented
Jan 30, 2023
| // Submit form so that the preference is persisted #5288 | ||
| formField.checked = true; | ||
| formField.form!.submit(); | ||
| event.preventDefault(); |
There was a problem hiding this comment.
My previous solution: 😱 catch the links and submit the existing form
My new solution: 😌 just create the form
| {makeLink('split', <BookIcon/>, !isUnified)} | ||
| </> | ||
| ); | ||
| } |
There was a problem hiding this comment.
So much dead code here, we haven't used half of this code for who knows how long
| attachElement(anchor, usesFloats ? { | ||
| after: () => ( | ||
| if (usesFloats) { | ||
| anchor.after( |
There was a problem hiding this comment.
attachElement wasn't needed here after all. Cleaner code
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
hide whitespaceas in the native Github #6200Test URLs
Demo
Lengthy video… it just demoes that the value is preserved after a refresh
Screen.Recording.2.mov