Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fetch correct item from cache after an ajax navigation #6280

Merged
merged 2 commits into from
Feb 2, 2023
Merged

Fetch correct item from cache after an ajax navigation #6280

merged 2 commits into from
Feb 2, 2023

Conversation

fregante
Copy link
Member

@fregante fregante commented Feb 1, 2023 •
edited

Test

  1. Open https://github.com/refined-github/sandbox in a new tab
  2. Click the "Refined GitHub" link in the readme

❌ Notice the "cool" tab appearing on "Refined GitHub"

  1. Refresh the page to see the right tag

Before

Screen.Recording.mov

After

Screen.Recording.1.mov

@fregante fregante added bug ajax Temporary label to collect Ajax issues labels Feb 1, 2023
@fregante fregante marked this pull request as ready for review February 2, 2023 06:29
@fregante fregante changed the title Fix API cache implementation Fetch correct item from cache after an ajax navigation Feb 2, 2023
@fregante fregante merged commit 0bd5176 into main Feb 2, 2023
@fregante fregante deleted the better-cache branch February 2, 2023 12:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
ajax Temporary label to collect Ajax issues bug
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Many features don't reset across different repositories
1 participant
@fregante