Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable link-to-github-io for .github.com repos #6303

Merged
merged 9 commits into from
Feb 11, 2023

Conversation

ambujsahu81
Copy link
Contributor

  1. closes #6228
  2. Affects old GitHub Pages repo like: resume/resume.github.com

Test URLs

resume/resume.github.com

Screenshot

  • Repo Header

repoheader

  • Repo List

repoListView

@ambujsahu81 ambujsahu81 changed the title Fix #6228: Link to github io only works on .github.io repos, but older ones are .github.com Fix #6228: link-to-github.io feature discards .github.com repos Feb 6, 2023
@ambujsahu81 ambujsahu81 marked this pull request as draft February 6, 2023 10:15
@FloEdelmann FloEdelmann changed the title Fix #6228: link-to-github.io feature discards .github.com repos Enable link-to-github-io for .github.com repos Feb 6, 2023
@ambujsahu81 ambujsahu81 marked this pull request as ready for review February 6, 2023 10:40
source/features/link-to-github-io.tsx Outdated Show resolved Hide resolved
source/features/link-to-github-io.tsx Outdated Show resolved Hide resolved
source/features/link-to-github-io.tsx Outdated Show resolved Hide resolved
source/features/link-to-github-io.tsx Outdated Show resolved Hide resolved
source/features/link-to-github-io.tsx Outdated Show resolved Hide resolved
source/features/link-to-github-io.tsx Outdated Show resolved Hide resolved
source/features/link-to-github-io.tsx Outdated Show resolved Hide resolved
source/features/link-to-github-io.tsx Outdated Show resolved Hide resolved
readme.md Outdated Show resolved Hide resolved
@fregante
Copy link
Member

fregante commented Feb 6, 2023

Thank you @ambujsahu81! I think this is ready for merge. I'll just keep it open a few days since we just released a new version and I'm not sure when the next one will be.

@ambujsahu81
Copy link
Contributor Author

Thank you @ambujsahu81! I think this is ready for merge. I'll just keep it open a few days since we just released a new version and I'm not sure when the next one will be.

@fregante that is fine , thank you for reviewing and suggestions .🙂

@fregante fregante merged commit ea9a5a3 into refined-github:main Feb 11, 2023
@fregante
Copy link
Member

Tested, it works! Thank you!

For future PRs, make sure you use a different branch every time to avoid checkout issues 😅

@ambujsahu81 ambujsahu81 deleted the patch-1 branch February 11, 2023 07:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

Link to github io only works on .github.io repos, but older ones are .github.com
3 participants