Make create-release-shortcut more resilient
#6324
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I'm not sure why this feature was added since creating releases is such a relatively rare action 🤷♂️ |
fregante
changed the title
create-release-shortcut more resilientcreate-release-shortcut feature
fregante
commented
Feb 11, 2023
| @@ -3,7 +3,7 @@ import * as pageDetect from 'github-url-detection'; | |||
|
|
|||
| import features from '../feature-manager'; | |||
|
|
|||
| export default function addQuickSubmit(): void { | |||
| function addQuickSubmit(): void { | |||
There was a problem hiding this comment.
The fun part was that this part of the feature was being exported from submission-via-ctrl-enter-everywhere, duplicating it entirely
fregante
changed the title
create-release-shortcut featurecreate-release-shortcut more resilient
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It seems that all shortcuts (even native ones) are broken at the moment 🤷♂️ but it should fix the first part of:
tag-changes-link#5884Test URLs
https://github.com/refined-github/refined-github/releases
https://github.com/refined-github/sandbox/releases/new
https://github.com/refined-github/sandbox/releases/tag/cool
Screenshot
Unable to test since it's natively broken